Conversation
Instead of creating a separate findUserVariant function that iterates through messages, access the variant directly from the baseMessage that is already passed to createSyntheticUserMessage.
fix: use variant from baseMessage in synthetic user message
…' into fix/variant-support
fix: propagate variant to notification messages
The isInternalAgent flag was causing a race condition where concurrent internal agents (title/summary generators) would set the flag to true, and normal session message transforms would see the stale value and skip injecting the prunable-tools list. This happened because messages.transform runs before system.transform, so the flag set by system.transform was always stale by the time messages.transform checked it. Fix: Remove the flag entirely and only skip system prompt injection for internal agents (detected in system.transform where it works reliably).
fix: remove isInternalAgent flag due to hook ordering race condition
chore: bump version to 1.1.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix variant support for synthetic messages
fix race condition from trying to prevent injections into internal agents. Currently the system prompt mods aren't injected but synthetic user messages still are for internal agents. Maybe this isn't a problem?